-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create currency modal with react-native-permissions and geolocation #3015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Julesssss @trjExpensify @iwiznia @rameshhpathak
Details
This PR is a copy of #2194 with some added changes to fix the broken build on iOS. I was unable to push to that branch since it's not in this repo, so creating a separate PR for it here. Since @rameshpathak is unable to test on iOS and this has become a priority, this PR has the changes required to make the build work again.
The main issue was that the Build Phases for the xcode project were out of order and there was an additional build phase, causing the
multiple commands produce
error.Fixed Issues
Fixes #1970
Tests
QA Steps
Same as tests
Tested On
Screenshots